How to do good code reviews
- Set measurable goals and capture metrics, but do not set too many. Good code must work as intended, have high readability, and perform optimally.
- Ask deep questions and confirm your understanding at each step, until your knowledge of the code is as good as the developer’s.
- Address everything you may think relevant, not just what you were told.
- Look for code that is repeated, non-modular, or flouting standard conventions.
- Avoid reviewing code for more than 60 minutes or more than 400 lines at a time. Increase the frequency of reviews so you can take time to identify the best solutions.
Full post here, 6 mins read